[18.0] Party data improvements - #329
Merged
Merged
Conversation
display_name might give unexpected results concatenating multiple fields.
OCA-git-bot
added
series:18.0
mod:edi_sale_ubl_output_oca
simahawk
changed the title
OCA-git-bot
added
the
mod:edi_exchange_template_party_data
santostelmo
approved these changes
Aug 20, 2026
Contributor
Author
|
/ocabot merge minor |
Contributor
|
This PR looks fantastic, let's merge it! |
Contributor
|
Congratulations, your PR was merged at 24aef1d. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See atomic commits for details.
Impact: only for the ones using party data in exchange templates. There the display_name will be replace w/ name but that's not a problem for 99% of the cases.
Spoiler: once this is merged I'll drop component dependency for basic party data and deprecate
edi_exchange_template_party_data.